improve performance in a number of scenarios (isinrole checks for anonymous users, and sensible cacheable attribute defaults)

Description

improve performance in a number of scenarios (isinrole checks for anonymous users, and sensible cacheable attribute defaults)

QA Test Plan

None

Activity

Show:
cathal connolly
August 26, 2014, 4:48 PM

changes come from Oliver Hine's contribution at https://github.com/dnnsoftware/Dnn.Platform/pull/137

Ben Zhong
September 17, 2014, 11:29 PM

IMO the CachableAttribute should update as:
public CacheableAttribute() : this(string.Empty, CacheItemPriority.Default, 20){}

but not initial properties directly in this constructor.

Ken Grierson
September 28, 2014, 9:09 PM

Comment from Ben:

which I think need some change as I comment on the issue. Currently the code works, just IMO use constructor inherit will be better.

cathal connolly
September 29, 2014, 2:11 PM

applied code review suggestion in 116 build

Ken Grierson
September 29, 2014, 11:56 PM

This all looks good.
Caching throws no errors from this change
Anonymous user SQL calls are reduced

Assignee

Ken Grierson

Reporter

cathal connolly

Story Size

Unknown

Severity

Major

Triage

New

Fixed in Build

Dev Owner

None

Includes Code Fix

No

Documentation Required

No

Trouble Ticket

None

Requires More Info

None

QA Story Points

None

QA Owner

None

Injected

None

Automation Required

None

Code Review Owner

None

Components

Fix versions

Affects versions

Priority

High
Configure