fix issue in upgrade script that caused issues with unicode characters when upgrading
Description
The file "Upgrade.cs", function "UpgradeToVersion721" contains typos on lines 2828:
using (var reader = DataProvider.Instance().ExecuteSQL("SELECT UserId, Username FROM {databaseOwner}[{objectQualifier}Users] WHERE Username LIKE '%&%'"))
and 2832:
var userId = Convert.ToInt32(reader["UserId"]);
On both lines the column name "UserId" should be "UserID". Note the lower case "d" in the original, it should be an upper case "D". Fixing this problem will allow the usage of this application in case sensitive SQL environments.
QA Test Plan
Activity
Jan,
DNN is storing all language specific texts as Unicode, which means there is usually no need to use a case sensitive collation on the database, except for comparisons (which are usually not applied to text, only to keys)
Hello Sebastian,
I agree with your "camelcase" opinion. That was the first thought I had at the beginning of solving this problem. Theoretically. Then I looked at the code, and for the sake of my health I decided to choose the easier way. The code of the application is very complex, and it is visible that many developers are working on it. Problem also is that not everyone understands the same thing under "camelcase". For example, someone writes "codeSubDirectory", and someone else writes "codeSubdirectory". I have seen this in the code. Which one is correct? In general I agree with enforcing a default notation style (such as "camelcase"). But how?
jan, of course there are a couple of names, where there might be multiple alternatives, but it is necessary to use same spelling on all tables, views and sprocs, where the column (or a local variable) is used, otherwise it becomes a nightmare.
Verified the changed code exists
Does not impact installation in case insensitive SQL databases.
Re-verified the changed code exists and that it does not impact installation in case insensitive SQL databases.
Platform 7.3.4 build 45
Assignee
Reporter
Story Size
Severity
Triage
Reported in Build #
Fixed in Build
Dev Owner
Includes Code Fix
Documentation Required
Trouble Ticket
Requires More Info
QA Story Points
QA Owner
Injected
Automation Required
Code Review Owner
Components
Fix versions
Affects versions
Priority
