fix issue in upgrade script that caused issues with unicode characters when upgrading

Description

The file "Upgrade.cs", function "UpgradeToVersion721" contains typos on lines 2828:

using (var reader = DataProvider.Instance().ExecuteSQL("SELECT UserId, Username FROM {databaseOwner}[{objectQualifier}Users] WHERE Username LIKE '%&%'"))

and 2832:

var userId = Convert.ToInt32(reader["UserId"]);

On both lines the column name "UserId" should be "UserID". Note the lower case "d" in the original, it should be an upper case "D". Fixing this problem will allow the usage of this application in case sensitive SQL environments.

QA Test Plan

None

Activity

Show:
Sebastian Leupold
August 29, 2014, 9:48 AM

Jan,
DNN is storing all language specific texts as Unicode, which means there is usually no need to use a case sensitive collation on the database, except for comparisons (which are usually not applied to text, only to keys)

Jan Durian
August 29, 2014, 9:52 AM

Hello Sebastian,
I agree with your "camelcase" opinion. That was the first thought I had at the beginning of solving this problem. Theoretically. Then I looked at the code, and for the sake of my health I decided to choose the easier way. The code of the application is very complex, and it is visible that many developers are working on it. Problem also is that not everyone understands the same thing under "camelcase". For example, someone writes "codeSubDirectory", and someone else writes "codeSubdirectory". I have seen this in the code. Which one is correct? In general I agree with enforcing a default notation style (such as "camelcase"). But how?

Sebastian Leupold
August 29, 2014, 9:55 AM

jan, of course there are a couple of names, where there might be multiple alternatives, but it is necessary to use same spelling on all tables, views and sprocs, where the column (or a local variable) is used, otherwise it becomes a nightmare.

Ken Grierson
September 3, 2014, 11:57 PM

Verified the changed code exists
Does not impact installation in case insensitive SQL databases.

Ken Grierson
November 4, 2014, 8:57 PM

Re-verified the changed code exists and that it does not impact installation in case insensitive SQL databases.
Platform 7.3.4 build 45

Assignee

Unassigned

Reporter

Jan Durian

Story Size

Unknown

Severity

Major

Triage

Triaged

Reported in Build #

07.03.02 (109)

Fixed in Build

Dev Owner

None

Includes Code Fix

Yes

Documentation Required

No

Trouble Ticket

None

Requires More Info

None

QA Story Points

None

QA Owner

None

Injected

None

Automation Required

None

Code Review Owner

None

Components

Fix versions

Affects versions

Priority

Low
Configure