Uploaded image for project: 'DNN Platform'
  1. DNN-8479

Also import PDB-files in addition to dll files in the installer-assembly area

    Details

    • Story Points:
      1
    • Story Size:
      XS
    • Severity:
      Minor
    • Triage:
      Triaged
    • Includes Code Fix:
      Yes
    • Sprint:
      9.1.1 Sprint 5, 9.1.1 - Regression

      Description

      When users install our modules and run into an error, they have trouble reporting what exactly the error is, because the stack in the events-module is not really helpful.

      BUT there is a solution: if we deploy the built PDB files from visual studio together with the .DLL files, then the error messages include exact line numbers. This is very helpful in fixing issues.

      PDB files have no security implication, they are like JS-map files and only help the error-system inform the user about the code-line where something happened.

      Because of this, it's important that we can also include the PDB files in the installation. Unfortunately as of now, the installer blocks this extension - telling the user it's unsafe.

      We should add pdb-files to the list of allowed files in the assembly installer to aid in better user error-feedback.

      The fix is to replace this

      /// -----------------------------------------------------------------------------
      /// <summary>
      /// Gets a list of allowable file extensions (in addition to the Host's List)
      /// </summary>
      /// <value>A String</value>
      public override string AllowableFiles
      {
      get

      { return "dll"; }

      }

      with this

      /// -----------------------------------------------------------------------------
      /// <summary>
      /// Gets a list of allowable file extensions (in addition to the Host's List)
      /// </summary>
      /// <value>A String</value>
      public override string AllowableFiles
      {
      get

      { return "dll, pdb"; }

      }

      on lines 104 to 115 in the AssemblyInstaller.cs - linked here: https://github.com/dnnsoftware/Dnn.Platform/blob/115ae75da6b152f77ad36312eb76327cdc55edd7/DNN%20Platform/Library/Services/Installer/Installers/AssemblyInstaller.cs#L104-L115

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              iJungleBoy Daniel Mettler
            • Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support