Upgrade ClientDependency.Core source code to latest

Description

The original ClientDependency source code package is hosted here https://github.com/Shazwazza/ClientDependency

We need to do the following:

  1. update DNN's ClientDependency source code with the latest original, and

  2. tag the created DLL assembly and file versions with the correct version number for easier identification

QA Test Plan

None

Activity

Show:
Ben Zhong
October 17, 2017, 3:54 AM
Edited

The author submitted a new PR https://github.com/dnnsoftware/Dnn.Platform/pull/1891 and merged as well, should available in platform 9.2.0.173-390 build.

This can be verified by modify DesktopModules\CoreMessaging\View.ascx, set line 10 to:
<dnnnnJsInclude ID="DnnJsInclude2" runat="server" FilePath="~/Resources/Shared/Components/ComposeMessage/ComposeMessage.js" Priority="101"HtmlAttributesAsString="aaa:aaa,bbb:bbb" />

then browse to /Activity-Feed/Messages page, check the source code and try find node of "ComposeMessage.js", it will render as:

Ehab Anshad
November 15, 2017, 8:02 AM

& We are seeing lots of minification errors across the platform, even if the minification option is disabled in settings.
Wondering if this related to this core library updated? if so please help us identify the quired regression scope because this is impacting everything. Thank you

Ehab Anshad
December 13, 2017, 2:42 PM

& Could you please confirm if we are good to verify this ticket now?

Ben Zhong
December 14, 2017, 12:14 AM

Hi , i think this item is good to go, if you find any problems within this area, we can log new JIRA to tracking the problems, there is no pending on this item. thanks,

Ehab Anshad
December 29, 2017, 11:43 AM

Verified using Chrome + Filddler for Platform 9.2.0.292-604
Verified scenario is:

  1. Create a page

  2. Increate the version number to force reloading (PB > Settings > Servers > Performance)

  3. Open Chrome private session and fiddler

  4. Open the created page URL then login wait till page loaded successfully

  5. Stop fiddler capturing

  6. Enable CDF, JS and CSS minification and increase the version number from PB > Settings > Servers > performance

  7. Repeat steps 3-5

  8. Sort by URl and compare the files

Results:

  • No issues found in the scenario from UI perspective

  • The Js, Css and Html files look identical with smaller size after minification.

Assignee

Unassigned

Reporter

George Alatrash

Story Size

M

Severity

Major

Triage

Triaged

Fixed in Build

Platform 9.2.0.173-390

Dev Owner

George Alatrash

Includes Code Fix

No

Documentation Required

No

Trouble Ticket

None

Requires More Info

None

QA Story Points

1

QA Owner

Ehab Anshad

Injected

None

Automation Required

No

Code Review Owner

None

Story Points

3

Components

Sprint

None

Fix versions

Affects versions

Priority

Low
Configure