The original ClientDependency source code package is hosted here https://github.com/Shazwazza/ClientDependency
We need to do the following:
update DNN's ClientDependency source code with the latest original, and
tag the created DLL assembly and file versions with the correct version number for easier identification
The author submitted a new PR https://github.com/dnnsoftware/Dnn.Platform/pull/1891 and merged as well, should available in platform 188.8.131.52-390 build.
This can be verified by modify DesktopModules\CoreMessaging\View.ascx, set line 10 to:
<dnnnnJsInclude ID="DnnJsInclude2" runat="server" FilePath="~/Resources/Shared/Components/ComposeMessage/ComposeMessage.js" Priority="101"HtmlAttributesAsString="aaa:aaa,bbb:bbb" />
then browse to /Activity-Feed/Messages page, check the source code and try find node of "ComposeMessage.js", it will render as:
& We are seeing lots of minification errors across the platform, even if the minification option is disabled in settings.
Wondering if this related to this core library updated? if so please help us identify the quired regression scope because this is impacting everything. Thank you
& Could you please confirm if we are good to verify this ticket now?
Hi , i think this item is good to go, if you find any problems within this area, we can log new JIRA to tracking the problems, there is no pending on this item. thanks,
Verified using Chrome + Filddler for Platform 184.108.40.2062-604
Verified scenario is:
Create a page
Increate the version number to force reloading (PB > Settings > Servers > Performance)
Open Chrome private session and fiddler
Open the created page URL then login wait till page loaded successfully
Stop fiddler capturing
Enable CDF, JS and CSS minification and increase the version number from PB > Settings > Servers > performance
Repeat steps 3-5
Sort by URl and compare the files
No issues found in the scenario from UI perspective
The Js, Css and Html files look identical with smaller size after minification.